Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rusty-jwt-tools to latest release, 0.11.0 #721

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

istankovic
Copy link
Member

No description provided.

@istankovic istankovic requested a review from a team as a code owner October 21, 2024 12:08
Copy link

github-actions bot commented Oct 21, 2024

🐰 Bencher Report

Branchivan/update-rjt
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
Commit add f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
17,958,000.00
Commit add f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6,734,800.00
Commit add f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
9,216,300.00
Commit add f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
11,374,000.00
Commit add f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
14,416,000.00
Commit add f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
16,088,000.00
Commit add f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
973,330,000.00
Commit add f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
6,665,000.00
Commit add f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
83,745,000.00
Commit add f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
217,440,000.00
Commit add f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
419,640,000.00
Commit add f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
665,450,000.00
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
115,680,000.00
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
28,323,000.00
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
46,975,000.00
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
60,174,000.00
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
78,645,000.00
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
93,289,000.00
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
🚷 view threshold
18,277,000.00
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
🚷 view threshold
113,930,000.00
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
🚷 view threshold
34,789,000.00
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
🚷 view threshold
56,002,000.00
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
🚷 view threshold
74,522,000.00
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
🚷 view threshold
94,123,000.00
Commit remove f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
26,266,000.00
Commit remove f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6,558,700.00
Commit remove f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
8,771,200.00
Commit remove f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
11,322,000.00
Commit remove f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
16,862,000.00
Commit remove f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
21,384,000.00
Commit remove f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
29,761,000.00
Commit remove f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
137,120,000.00
Commit remove f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
114,620,000.00
Commit remove f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
92,786,000.00
Commit remove f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
71,308,000.00
Commit remove f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
50,002,000.00
Commit update f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
136,440,000.00
Commit update f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6,763,500.00
Commit update f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
33,240,000.00
Commit update f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
59,220,000.00
Commit update f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
85,674,000.00
Commit update f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
111,470,000.00
Count KeyPackage/cs1/mem/1002📈 view plot
🚷 view threshold
9,743,200.00
Count KeyPackage/cs1/mem/2📈 view plot
🚷 view threshold
6,369,900.00
Count KeyPackage/cs1/mem/202📈 view plot
🚷 view threshold
7,090,700.00
Count KeyPackage/cs1/mem/402📈 view plot
🚷 view threshold
7,915,600.00
Count KeyPackage/cs1/mem/602📈 view plot
🚷 view threshold
8,586,400.00
Count KeyPackage/cs1/mem/802📈 view plot
🚷 view threshold
8,982,500.00
Create group/cs1/mem📈 view plot
🚷 view threshold
6,315,000.00
Decrypt f(msg size)/cs1/mem/10📈 view plot
🚷 view threshold
6,206,900.00
Decrypt f(msg size)/cs1/mem/10010📈 view plot
🚷 view threshold
6,326,000.00
Decrypt f(msg size)/cs1/mem/2010📈 view plot
🚷 view threshold
6,269,700.00
Decrypt f(msg size)/cs1/mem/4010📈 view plot
🚷 view threshold
6,266,900.00
Decrypt f(msg size)/cs1/mem/6010📈 view plot
🚷 view threshold
6,245,300.00
Decrypt f(msg size)/cs1/mem/8010📈 view plot
🚷 view threshold
6,354,900.00
Encrypt f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
8,316,400.00
Encrypt f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6,295,600.00
Encrypt f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
6,913,400.00
Encrypt f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
7,160,500.00
Encrypt f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
7,632,900.00
Encrypt f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
8,118,400.00
Encrypt f(msg size)/cs1/mem/10📈 view plot
🚷 view threshold
9,691,900.00
Encrypt f(msg size)/cs1/mem/10010📈 view plot
🚷 view threshold
8,878,700.00
Encrypt f(msg size)/cs1/mem/2010📈 view plot
🚷 view threshold
8,497,200.00
Encrypt f(msg size)/cs1/mem/4010📈 view plot
🚷 view threshold
8,804,900.00
Encrypt f(msg size)/cs1/mem/6010📈 view plot
🚷 view threshold
8,649,700.00
Encrypt f(msg size)/cs1/mem/8010📈 view plot
🚷 view threshold
8,657,700.00
Generate KeyPackage f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
241,630,000.00
Generate KeyPackage f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6,420,500.00
Generate KeyPackage f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
32,922,000.00
Generate KeyPackage f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
85,202,000.00
Generate KeyPackage f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
138,570,000.00
Generate KeyPackage f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
189,750,000.00
Join from external commit f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
241,410,000.00
Join from external commit f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
7,462,400.00
Join from external commit f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
54,223,000.00
Join from external commit f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
101,030,000.00
Join from external commit f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
148,510,000.00
Join from external commit f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
195,390,000.00
Join from welcome f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
112,970,000.00
Join from welcome f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
7,026,000.00
Join from welcome f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
28,333,000.00
Join from welcome f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
49,575,000.00
Join from welcome f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
71,149,000.00
Join from welcome f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
92,436,000.00
Mls vs Proteus: add/MLS/mem/1📈 view plot
🚷 view threshold
6,623,600.00
Mls vs Proteus: add/MLS/mem/101📈 view plot
🚷 view threshold
7,868,500.00
Mls vs Proteus: add/MLS/mem/21📈 view plot
🚷 view threshold
6,977,000.00
Mls vs Proteus: add/MLS/mem/41📈 view plot
🚷 view threshold
7,279,600.00
Mls vs Proteus: add/MLS/mem/61📈 view plot
🚷 view threshold
7,489,800.00
Mls vs Proteus: add/MLS/mem/81📈 view plot
🚷 view threshold
7,720,600.00
Mls vs Proteus: add/Proteus/mem/1📈 view plot
🚷 view threshold
6,409,400.00
Mls vs Proteus: add/Proteus/mem/101📈 view plot
🚷 view threshold
44,866,000.00
Mls vs Proteus: add/Proteus/mem/21📈 view plot
🚷 view threshold
14,272,000.00
Mls vs Proteus: add/Proteus/mem/41📈 view plot
🚷 view threshold
22,017,000.00
Mls vs Proteus: add/Proteus/mem/61📈 view plot
🚷 view threshold
29,676,000.00
Mls vs Proteus: add/Proteus/mem/81📈 view plot
🚷 view threshold
37,329,000.00
Mls vs Proteus: encrypt/MLS/mem/1📈 view plot
🚷 view threshold
6,219,500.00
Mls vs Proteus: encrypt/MLS/mem/101📈 view plot
🚷 view threshold
6,518,700.00
Mls vs Proteus: encrypt/MLS/mem/21📈 view plot
🚷 view threshold
6,427,100.00
Mls vs Proteus: encrypt/MLS/mem/41📈 view plot
🚷 view threshold
6,335,200.00
Mls vs Proteus: encrypt/MLS/mem/61📈 view plot
🚷 view threshold
6,320,700.00
Mls vs Proteus: encrypt/MLS/mem/81📈 view plot
🚷 view threshold
6,353,200.00
Mls vs Proteus: encrypt/Proteus/mem/1📈 view plot
🚷 view threshold
6,142,800.00
Mls vs Proteus: encrypt/Proteus/mem/101📈 view plot
🚷 view threshold
16,031,000.00
Mls vs Proteus: encrypt/Proteus/mem/21📈 view plot
🚷 view threshold
8,114,800.00
Mls vs Proteus: encrypt/Proteus/mem/41📈 view plot
🚷 view threshold
10,039,000.00
Mls vs Proteus: encrypt/Proteus/mem/61📈 view plot
🚷 view threshold
11,897,000.00
Mls vs Proteus: encrypt/Proteus/mem/81📈 view plot
🚷 view threshold
15,327,000.00
Mls vs Proteus: remove/MLS/mem/1📈 view plot
🚷 view threshold
20,175,000.00
Mls vs Proteus: remove/MLS/mem/101📈 view plot
🚷 view threshold
7,862,400.00
Mls vs Proteus: remove/MLS/mem/21📈 view plot
🚷 view threshold
17,669,000.00
Mls vs Proteus: remove/MLS/mem/41📈 view plot
🚷 view threshold
15,180,000.00
Mls vs Proteus: remove/MLS/mem/61📈 view plot
🚷 view threshold
12,810,000.00
Mls vs Proteus: remove/MLS/mem/81📈 view plot
🚷 view threshold
10,429,000.00
Mls vs Proteus: remove/Proteus/mem/1📈 view plot
🚷 view threshold
5,826,600.00
Mls vs Proteus: remove/Proteus/mem/101📈 view plot
🚷 view threshold
6,990,100.00
Mls vs Proteus: remove/Proteus/mem/21📈 view plot
🚷 view threshold
6,115,600.00
Mls vs Proteus: remove/Proteus/mem/41📈 view plot
🚷 view threshold
6,624,700.00
Mls vs Proteus: remove/Proteus/mem/61📈 view plot
🚷 view threshold
6,827,100.00
Mls vs Proteus: remove/Proteus/mem/81📈 view plot
🚷 view threshold
7,122,100.00
Mls vs Proteus: update/MLS/mem/1📈 view plot
🚷 view threshold
6,717,200.00
Mls vs Proteus: update/MLS/mem/101📈 view plot
🚷 view threshold
20,096,000.00
Mls vs Proteus: update/MLS/mem/21📈 view plot
🚷 view threshold
9,664,800.00
Mls vs Proteus: update/MLS/mem/41📈 view plot
🚷 view threshold
12,320,000.00
Mls vs Proteus: update/MLS/mem/61📈 view plot
🚷 view threshold
14,792,000.00
Mls vs Proteus: update/MLS/mem/81📈 view plot
🚷 view threshold
17,656,000.00
Mls vs Proteus: update/Proteus/mem/1📈 view plot
🚷 view threshold
6,314,800.00
Mls vs Proteus: update/Proteus/mem/101📈 view plot
🚷 view threshold
46,591,000.00
Mls vs Proteus: update/Proteus/mem/21📈 view plot
🚷 view threshold
14,578,000.00
Mls vs Proteus: update/Proteus/mem/41📈 view plot
🚷 view threshold
22,497,000.00
Mls vs Proteus: update/Proteus/mem/61📈 view plot
🚷 view threshold
30,730,000.00
Mls vs Proteus: update/Proteus/mem/81📈 view plot
🚷 view threshold
39,379,000.00
🐰 View full continuous benchmarking report in Bencher

coriolinus
coriolinus previously approved these changes Nov 11, 2024
@@ -61,7 +61,7 @@ openmls_x509_credential = { git = "https://github.com/wireapp/openmls", rev = "6
proteus-traits = { git = "https://github.com/wireapp/proteus", tag = "v2.1.1" }
proteus-wasm = { git = "https://github.com/wireapp/proteus", tag = "v2.1.1" }

wire-e2e-identity = { git = "https://github.com/wireapp/rusty-jwt-tools", rev = "751f281ec75a6ae113584659b4b48940407c50f8", version = "0.9" }
wire-e2e-identity = { git = "https://github.com/wireapp/rusty-jwt-tools", tag = "v0.11.0" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes from specifying a minor version to specifying a patch version. That's probably fine, but I don't know if there's a standard policy or convention for how specifically we specify our dependency versions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we follow the usual version = ... pattern for things published on crates.io, however none of our internal crates are published (e.g. rusty-jwt-tools, proteus-related things, openmls fork...). For those we just point to a tag, like above.

@coriolinus coriolinus dismissed their stale review November 11, 2024 08:59

did not spot that rust tests were failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants