-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update rusty-jwt-tools to latest release, 0.11.0 #721
base: main
Are you sure you want to change the base?
Conversation
2184682
to
f486b16
Compare
@@ -61,7 +61,7 @@ openmls_x509_credential = { git = "https://github.com/wireapp/openmls", rev = "6 | |||
proteus-traits = { git = "https://github.com/wireapp/proteus", tag = "v2.1.1" } | |||
proteus-wasm = { git = "https://github.com/wireapp/proteus", tag = "v2.1.1" } | |||
|
|||
wire-e2e-identity = { git = "https://github.com/wireapp/rusty-jwt-tools", rev = "751f281ec75a6ae113584659b4b48940407c50f8", version = "0.9" } | |||
wire-e2e-identity = { git = "https://github.com/wireapp/rusty-jwt-tools", tag = "v0.11.0" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes from specifying a minor version to specifying a patch version. That's probably fine, but I don't know if there's a standard policy or convention for how specifically we specify our dependency versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we follow the usual version = ...
pattern for things published on crates.io, however none of our internal crates are published (e.g. rusty-jwt-tools, proteus-related things, openmls fork...). For those we just point to a tag, like above.
did not spot that rust tests were failing
No description provided.