Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default terminationGracePeriodSeconds #85

Merged
merged 1 commit into from
Jan 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/windmill/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ Windmill - Turn scripts into endpoints, workflows and UIs in minutes
| windmill.workerGroups[0].podSecurityContext.runAsUser | int | `0` | run as user. The default is 0 for root user |
| windmill.workerGroups[0].replicas | int | `3` | |
| windmill.workerGroups[0].resources | object | `{"limits":{"cpu":"1","memory":"2Gi"}}` | Resource limits and requests for the pods |
| windmill.workerGroups[0].terminationGracePeriodSeconds | int | `300` | If a job is being ran, the container will wait for it to finish before terminating until this grace period |
| windmill.workerGroups[0].terminationGracePeriodSeconds | int | `604800` | If a job is being ran, the container will wait for it to finish before terminating until this grace period |
| windmill.workerGroups[0].tolerations | list | `[]` | Tolerations to apply to the pods |
| windmill.workerGroups[0].volumeMounts | list | `[]` | |
| windmill.workerGroups[0].volumes | list | `[]` | |
Expand Down
2 changes: 1 addition & 1 deletion charts/windmill/templates/worker-groups.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ spec:
{{- toYaml . | nindent 6 }}
{{- end }}
{{ end }}
terminationGracePeriodSeconds: {{ default 300 $v.terminationGracePeriodSeconds }}
terminationGracePeriodSeconds: {{ default 604800 $v.terminationGracePeriodSeconds }}
containers:
{{- with $v.extraContainers }}
{{- toYaml . | nindent 6 }}
Expand Down
2 changes: 1 addition & 1 deletion charts/windmill/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ windmill:
annotations: {}

# -- If a job is being ran, the container will wait for it to finish before terminating until this grace period
terminationGracePeriodSeconds: 300
terminationGracePeriodSeconds: 604800

# -- Labels to apply to the pods
labels: {}
Expand Down
Loading