#566: Replaces RecyclerView with GridView on edit phrases screen #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on preventing vertical scrolling)
kaffn8ed27
requested review from
nicholas-cook,
stechkev,
nerdsosky,
PaulKlauser and
mattttvaughn
as code owners
katiedotson
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOES NOT RESOLVE ENTIRE BUG
Description:
Replaces the RecyclerView in CustomCategoryPhraseListFragment with a GridView - the eventual goal is to dynamically measure the number of phrases that can fit on the screen so that there won't be scrolling; ergo, there's no need for a RecyclerView.
I did my best to accurately duplicate the existing design but please don't hesitate to raise any issues you see!
Screenshots:
Edit Phrase screen ("General" category) - new GridView version