Updates settings layouts in landscape #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cinadia
requested review from
nicholas-cook,
stechkev,
nerdsosky,
caroline-wang-320,
PaulKlauser and
mattttvaughn
as code owners
PaulKlauser
approved these changes
Jun 3, 2024
| @@ -240,6 +240,7 @@ | |||
| <dimen name="edit_individual_category_padding_end">0dp</dimen> | |||
| <dimen name="edit_individual_category_padding">10dp</dimen> | |||
| <dimen name="edit_individual_category_margin_top">20dp</dimen> | |||
| <dimen name="edit_individual_category_menu_margin">8dp</dimen> | |||
There was a problem hiding this comment.
For future reference (this is fine here), you could just put the 8dp in the layout itself. Typically it's nice to have "standard" padding values that are more generic eg. padding_1 padding_2 etc etc, that bucket things into the 8, 16, 24 point grid, but this project went overboard with very specific dimens that get declared and then only used like one time.
cinadia
force-pushed
the
380-individual-category-padding-match-parent
branch
from
472240d to
e5f9b36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Screenshots:
1.
Before:
After:
Before:
After:
Before:
After:
