Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 416: Migrate EditCategoryPhrasesFragment to use VocableFragmentStateAdapter #525

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Issue 416: Migrate EditCategoryPhrasesFragment to use VocableFragmentStateAdapter #525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 24 additions & 32 deletions app/src/main/java/com/willowtree/vocable/settings/EditCategoryPhrasesFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import com.willowtree.vocable.presets.Category
import com.willowtree.vocable.presets.Phrase
import com.willowtree.vocable.presets.PresetCategories
import com.willowtree.vocable.settings.customcategories.CustomCategoryPhraseListFragment
import com.willowtree.vocable.utils.LegacyFragmentStateAdapter
import com.willowtree.vocable.utils.VocableFragmentStateAdapter
import org.koin.androidx.viewmodel.ViewModelOwner
import org.koin.androidx.viewmodel.ext.android.viewModel

Expand Down Expand Up @@ -104,17 +104,16 @@ class EditCategoryPhrasesFragment : BaseFragment<FragmentEditCategoryPhrasesBind
}
}

binding.editCategoryPhraseHolder.registerOnPageChangeCallback(object :
ViewPager2.OnPageChangeCallback() {
override fun onPageSelected(position: Int) {
val pageNum = position % phrasesAdapter.numPages + 1
binding.editCategoryPageNumber.text = getString(
R.string.phrases_page_number,
pageNum,
phrasesAdapter.numPages
)
}
})
binding.editCategoryPhraseHolder.apply {
isSaveEnabled = false
adapter = phrasesAdapter
registerOnPageChangeCallback(object :
ViewPager2.OnPageChangeCallback() {
override fun onPageSelected(position: Int) {
post { updatePageNumber() }
}
})
}

subscribeToViewModel()

Expand Down Expand Up @@ -144,34 +143,27 @@ class EditCategoryPhrasesFragment : BaseFragment<FragmentEditCategoryPhrasesBind
binding.editCategoryPageNumber.isVisible = phrases.isNotEmpty()

if (phrases.isNotEmpty()) {
with(binding.editCategoryPhraseHolder) {
isSaveEnabled = false

adapter = phrasesAdapter

phrasesAdapter.setItems(phrases)

// Move adapter to middle so user can scroll both directions
val middle = phrasesAdapter.itemCount / 2
if (middle % phrasesAdapter.numPages == 0) {
setCurrentItem(middle, false)
} else {
val mod = middle % phrasesAdapter.numPages
setCurrentItem(
middle + (phrasesAdapter.numPages - mod),
false
)
}
}
phrasesAdapter.setItems(phrases)
}
}

private fun updatePageNumber() {
val currentPage = binding.editCategoryPhraseHolder.currentItem
val pageNum = currentPage % phrasesAdapter.numPages + 1
binding.editCategoryPageNumber.text = getString(
R.string.phrases_page_number,
pageNum,
phrasesAdapter.numPages
)
}

inner class PhrasesPagerAdapter(fm: FragmentManager) :
LegacyFragmentStateAdapter<Phrase>(fm, viewLifecycleOwner.lifecycle) {
VocableFragmentStateAdapter<Phrase>(fm, viewLifecycleOwner.lifecycle) {

override fun setItems(items: List<Phrase>) {
super.setItems(items)
setPagingButtonsEnabled(numPages > 1)
updatePageNumber()
}

private fun setPagingButtonsEnabled(enable: Boolean) {
Expand Down
Loading