Issue 416: Refactor pager code of edit categories screen #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josmith42
requested review from
nicholas-cook,
stechkev,
nerdsosky,
caroline-wang-320,
PaulKlauser and
mattttvaughn
as code owners
* VocableFragementStateAdapter:
* Fix return value of getItemCount()
* Replace notifyDataSetChanged() with notifyItemInserted() and notifyItemRemoved()
* EditCategoriesFragment:
* Use post {} for setting categoryPageNumber (wasn't always getting set correctly before)
* Move setting of adapter so that it's called once instead of every time data changes
* Remove broken setting of current page to "middle" (now defaults to first page)
* Make LegacyFragmentStateAdapter for use in other subclasses that haven't been changed yet
* EditCategoriesViewModel: liveOrderCategoryList and liveAddRemoveCategoryList in favor of a single categoryList that uses categories() flow from categoriesUseCase
* EditCategoriesListFragment: fix crash when removing an element caused pager to go down a page
josmith42
force-pushed
the
refactor/edit-categories-pager
branch
from
fec6fbe to
eb85a0a
Compare
|
Seeing something funky going on here. If you go to the categories page and keep trying to move the bottom most category on a page down, the moving doesn't happy as expected and if you do it enough it'll crash vocable_crash.webm |
josmith42
commented
Apr 11, 2024
| @@ -23,7 +24,15 @@ class FakeCategoriesUseCase : ICategoriesUseCase { | |||
| ) | |||
|
|
|||
| override fun categories(): Flow<List<Category>> { | |||
| return _categories | |||
| return _categories.map { | |||
There was a problem hiding this comment.
I had to make this change to get the fake to match the behavior of the real use case. (I know, I know. The real solution is to refactor the test to use the real use case. I am just not prepared to do that as a part of this PR.)
|
@mattttvaughn I fixed the crash you raised up. Please take a look! 🙏 |
mattttvaughn
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
VocableFragementStateAdapter:getItemCount()notifyDataSetChanged()withnotifyItemInserted()andnotifyItemRemoved()EditCategoriesFragment:post {}for settingcategoryPageNumber(wasn't always getting set correctly before)LegacyFragmentStateAdapterfor use in other subclasses that haven't been changed yetEditCategoriesViewModel: replaceliveOrderCategoryListandliveAddRemoveCategoryListin favor of a singlecategoryListthat usescategories()flow fromcategoriesUseCaseEditCategoriesListFragment: fix crash when removing an element caused pager to go down a pageScreenshots:
n/a