Rename PresetsRepository #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name already didn't match the responsibility of the class, and with the migration, the name was even more confusing.
PaulKlauser
requested review from
nicholas-cook,
jrtb,
stechkev,
nerdsosky,
jollygreenegiant,
willdenne and
caroline-wang-320
as code owners
Base automatically changed from
chore/452-abstract-over-saved-preset-categories-2
to
main
December 28, 2023 15:38
mattttvaughn
approved these changes
Dec 28, 2023
Comment on lines
+9
to
+10
| @Deprecated("This is the old way of accessing categories and phrases. Prefer using" + | ||
| " ICategoriesUseCase instead.") |
There was a problem hiding this comment.
Nit but would we want PhrasesUseCase mentioned in here as well?
There was a problem hiding this comment.
Good call, I forgot that existed
There was a problem hiding this comment.
I'ma fix this forward in a following PR 👍
|
PaulKlauser
deleted the
chore/452-abstract-over-saved-preset-categories-3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name already didn't match the responsibility of the class, and with the migration, the name was even more confusing.
#452