Fix Crash When Clicking "+" to Add New Category #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to add a new category on the categories page would previously result in a crash, as the Edit Categories page didn't handle opening the screen without a category passed in.
mattttvaughn
requested review from
nicholas-cook,
jrtb,
stechkev,
nerdsosky,
jollygreenegiant,
willdenne,
caroline-wang-320 and
PaulKlauser
as code owners
PaulKlauser
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a fresh install, attempting to add a new category on the categories page would previously result in a crash, as the Edit Categories page didn't handle opening the screen without a category passed in.
This is mentioned in #441. This PR just resolves a minor portion of that ticket, the "add new category" that is mentioned as a footnote.
STRs:
+buttonExpected:
The user is brought to a screen to add a new category.
Actual:
The app crashes.
Screenshots/videos:
