Androidx activityResult refactor #454
Conversation
IanCrossCD
force-pushed
the
androidx-activityresult-refactor
branch
from
35dce64 to
1d12e0e
Compare
IanCrossCD
requested review from
nicholas-cook,
jrtb,
stechkev,
nerdsosky,
jollygreenegiant,
willdenne,
caroline-wang-320 and
PaulKlauser
as code owners
app/src/main/java/com/willowtree/vocable/utils/FaceTrackingManager.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/willowtree/vocable/facetracking/FaceTrackFragment.kt
Outdated
Show resolved
Hide resolved
mattttvaughn
force-pushed
the
androidx-activityresult-refactor
branch
from
57130da to
870f6c0
Compare
mattttvaughn
force-pushed
the
androidx-activityresult-refactor
branch
from
870f6c0 to
7b3f2cc
Compare
| activity.registerForActivityResult(ActivityResultContracts.RequestPermission()) { isGranted: Boolean -> | ||
| if (isGranted) { | ||
| enableFaceTracking() | ||
| } else { | ||
| disableFaceTracking() | ||
| permissionSettingsDialog.show() | ||
| } | ||
| } |
There was a problem hiding this comment.
all the new stuff in this file is just moved wholesale from CameraPermissionsHelper. The only intended changes are to directly use enableFaceTracking() or disableFaceTracking() instead of calling them via callbacks
There was a problem hiding this comment.
Since enable/disable are now called internally, do they still need to be part of the public interface here?
This then feeds into how this class is being tested, which I think is going to inform whether or not your mocking below is sufficient. My gut says it's not, since you're now unable to test the various branching points at line 49
| return FaceTrackingPermissions( | ||
| sharedPreferences = sharedPreferences, | ||
| activity = mockk(relaxed = true) | ||
| ) |
There was a problem hiding this comment.
holler if there's a better approach since I know relaxed mocks are probably a code smell, but an activity is required in this class now and doing interface shenanigans didn't feel worth the time/complexity to me
There was a problem hiding this comment.
Can these Fakes go in the test directory?
Description:
Migrates FaceTrackingManager Camera Permissions to Androidx activityResult. Creates CameraPermissionHelper