Implement adding a Category in CategoriesUseCase #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulKlauser
requested review from
nicholas-cook,
jrtb,
stechkev,
nerdsosky,
jollygreenegiant,
willdenne and
caroline-wang-320
as code owners
IanCrossCD
reviewed
Nov 28, 2023
| @@ -49,10 +46,9 @@ class CategoriesUseCase( | |||
| } | |||
|
|
|||
| override suspend fun addCategory(categoryName: String, sortOrder: Int) { | |||
| presetsRepository.addCategory( | |||
There was a problem hiding this comment.
Is the PresetsRepository.addCategory still used?
There was a problem hiding this comment.
Great ask, looks like it's not
| @@ -49,10 +46,9 @@ class CategoriesUseCase( | |||
| } | |||
|
|
|||
| override suspend fun addCategory(categoryName: String, sortOrder: Int) { | |||
There was a problem hiding this comment.
Separate discussions from your code but I'm curious on your thoughts on these sort of mono use cases.
There was a problem hiding this comment.
Meaning, use cases that can do more than one thing? I don't have super strong feelings, and I know a lot of folks go with the one-operation use cases, but I find that doesn't buy you a whole lot for the extra verbosity. What are your thoughts?
There was a problem hiding this comment.
It doesn't buy you much for sure. It feel like its conflating two patterns but doesn't feel too wrong otherwise.
PaulKlauser
deleted the
chore/452-abstract-over-saved-preset-categories
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implement adding a Category in CategoriesUseCase