Creates FaceTrackingManager #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent for selectionModeViewModel as global state
IanCrossCD
requested review from
nicholas-cook,
jrtb,
stechkev,
nerdsosky,
jollygreenegiant,
willdenne,
caroline-wang-320 and
PaulKlauser
as code owners
IanCrossCD
force-pushed
the
facetrackingmanager-util-refactor
branch
from
0a43a91 to
e3ca8b7
Compare
PaulKlauser
requested changes
Nov 27, 2023
app/src/main/java/com/willowtree/vocable/utils/FaceTrackingManager.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/com/willowtree/vocable/utils/FaceTrackingPermissionsTest.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/com/willowtree/vocable/settings/selectionmode/SelectionModeViewModelTest.kt
Outdated
Show resolved
Hide resolved
IanCrossCD
force-pushed
the
facetrackingmanager-util-refactor
branch
from
4d0dea0 to
56156b9
Compare
PaulKlauser
approved these changes
Nov 29, 2023
app/src/main/java/com/willowtree/vocable/utils/FaceTrackingManager.kt
Outdated
Show resolved
Hide resolved
…aceTrackingManager. checkIsSupportedDeviceOrFinish no longer finishes activity. New tests use Junit assert.
IanCrossCD
force-pushed
the
facetrackingmanager-util-refactor
branch
from
56156b9 to
c1bb122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Creates FaceTrackingManager to isolate face tracking logic out of MainActivity. Mostly moves low hanging fruit out of activity at this time.