Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable ui tests #444

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Re-enable ui tests #444

merged 1 commit into from
Jan 26, 2024

Conversation

acosta434
Copy link
Contributor

@acosta434 acosta434 commented Nov 16, 2023 •
edited
Loading

Re-enable tests to see if they run in current pipeline

Description:

  • Removed ignore from existing tests
  • Update string to fix failing test
  • Add step to dismiss ArCoredialog

Screenshots:
n/a

  • Acceptance Criteria satisfied
  • Regression Testing

@SashankPatel SashankPatel linked an issue Nov 27, 2023 that may be closed by this pull request
Add UI tests to pipeline #447
Closed
PaulKlauser
PaulKlauser requested changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@PaulKlauser PaulKlauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, see my comments. Can we squash these commits down as well?

app/src/androidTest/java/com/willowtree/vocable/tests/BaseTest.kt Show resolved Hide resolved
app/src/androidTest/java/com/willowtree/vocable/tests/BaseTest.kt Outdated Show resolved Hide resolved
app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
@acosta434 acosta434 force-pushed the task/enable-ui-tests branch from eb82137 to 5842066 Compare January 25, 2024 18:45
@acosta434 acosta434 force-pushed the task/enable-ui-tests branch from f0812e3 to 5e1873d Compare January 25, 2024 20:35
@acosta434
Copy link
Contributor Author

@PaulKlauser I got it down to the 1 commit.

@PaulKlauser PaulKlauser merged commit 97e214c into main Jan 26, 2024
4 checks passed
@PaulKlauser PaulKlauser deleted the task/enable-ui-tests branch January 26, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulKlauser PaulKlauser PaulKlauser approved these changes

@nicholas-cook nicholas-cook Awaiting requested review from nicholas-cook nicholas-cook is a code owner

@jrtb jrtb Awaiting requested review from jrtb

@stechkev stechkev Awaiting requested review from stechkev stechkev is a code owner

@nerdsosky nerdsosky Awaiting requested review from nerdsosky nerdsosky is a code owner

@jollygreenegiant jollygreenegiant Awaiting requested review from jollygreenegiant

@willdenne willdenne Awaiting requested review from willdenne

@caroline-wang-320 caroline-wang-320 Awaiting requested review from caroline-wang-320

@mattttvaughn mattttvaughn Awaiting requested review from mattttvaughn mattttvaughn is a code owner

Assignees

@rijulkochar rijulkochar

@acosta434 acosta434

Labels
Automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add UI tests to pipeline
3 participants
@acosta434 @PaulKlauser @rijulkochar