VOC-401 More intuatively asks for Camera permissions. #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanCrossCD
force-pushed
the
401-camera-permission-rework
branch
2 times, most recently
from
b2537fd to
3b70f96
Compare
IanCrossCD
requested review from
nicholas-cook,
jrtb,
stechkev,
nerdsosky,
jollygreenegiant,
willdenne,
caroline-wang-320 and
PaulKlauser
as code owners
IanCrossCD
force-pushed
the
401-camera-permission-rework
branch
4 times, most recently
from
fb6011b to
5f2c623
Compare
…enied turns off tracking UI and disables button.
IanCrossCD
force-pushed
the
401-camera-permission-rework
branch
from
5f2c623 to
e3f1c33
Compare
PaulKlauser
requested changes
Nov 17, 2023
There was a problem hiding this comment.
I like the direction. Consolidating the control of the head tracking enabled/disabled state is awesome. Seeing this got me thinking you might be able to take it even further and get more stuff out of the Activity. Let me know what you think of my comments.
Also, in the name of reducing change size, I'm cool merging this once the typos and potential left-behind things are addressed, and handling moving more logic around in another PR.
app/src/main/java/com/willowtree/vocable/facetracking/FaceTrackFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/willowtree/vocable/facetracking/FaceTrackFragment.kt
Show resolved
Hide resolved
app/src/main/java/com/willowtree/vocable/utils/IVocableSharedPreferences.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/com/willowtree/vocable/settings/selectionmode/SelectionModeViewModelTest.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/com/willowtree/vocable/settings/selectionmode/SelectionModeViewModelTest.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/willowtree/vocable/settings/selectionmode/SelectionModeViewModel.kt
Show resolved
Hide resolved
IanCrossCD
force-pushed
the
401-camera-permission-rework
branch
6 times, most recently
from
7aea449 to
5da3d58
Compare
…checks, Re-adds statusbar fullscreen mode
IanCrossCD
force-pushed
the
401-camera-permission-rework
branch
from
3ec8090 to
fb6e85d
Compare
PaulKlauser
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Only asks for permissions if attempting to enable head tracking.
Includes rational dialog to improve approval chances.
Does not enable
headTrackingFragmentuntil permissions are enabled the first time. Pauses and resumes fragment to any changes after the fact.Always checks permissions before turning on headTracking.