Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jv-keyboard.js #789

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Update jv-keyboard.js #789

merged 3 commits into from
Aug 30, 2024

Conversation

bennylin
Copy link
Contributor

Add common shortcuts, fix bug, change url link

Please merge, because the bug is quite severe, I've asked the bugfix since last year #760 760

@srish
Copy link
Member

srish commented Aug 28, 2024

@bennylin Thanks for this patch! We will review it shortly. In the meantime, could you also create a task on Phabricator around this explaining in a few lines what is the issue this pull request is trying to address? You can then add LPL Technical Support tag to the task, assign it to yourself, and share link to this pull request in a comment on the task.

Copy link
Member

@srish srish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the new characters you added, you might want to expand the test cases here:

inputmethod: 'jv-keyboard',

@bennylin
Copy link
Contributor Author

Is this a new procedure? Why two places and not centralized here? I have many PR that are waiting for review since last year while collecting dust. Do you want me to create ticket for each of them?

Copy link
Member

@srish srish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amire80 I have tested this PR and these changes look good to me. Could you take another look and merge it?

Add common shortcuts, fix bug, change url link
change the order
@srish
Copy link
Member

srish commented Aug 30, 2024

@bennylin Thanks for creating the task! I requested that it be added to Phabricator so it can be prioritized more effectively. Apologies that your other pull requests haven't received attention. We hope to improve in this area!

@srish srish merged commit 9ee9bc8 into wikimedia:master Aug 30, 2024
3 checks passed
@bennylin
Copy link
Contributor Author

Thanks @srish !

@bennylin bennylin deleted the jv-keyboard-update branch August 31, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants