Performance, caching optimizations #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
February 15, 2024 22:03
Experimenting performance improvements.
Presidio was doing some init work outside of the init method without caching. Also, workflows now return metadata about performance times.
We need to be able to not download torch so we can control it from consuming applications.
Making everything explicit since it isn't clear that this object isn't the primary output of the api.
added 4 commits
February 17, 2024 15:04
Apparently the new version of spacy doesn't pull down packages automatically via .load() anymore. Now you have to explicitly download the package first. They don't have an api intended for python use but their CLI is python and you can still call it directly. They don't have a nice way of pinning the version yet though, short of copying the github url that they use to store the wheels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.