FTOK() collisions #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inode instead will prevent collisions especially when using temp files for shared memory storage.
|
It's been years ago since you've opened this PR, but feel free to open it over here at https://github.com/maksimovic/simple-fork-php I needed this to be compatible with PHP 7.2+ (8 included) and eventually had it released as a separate package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ftok() can have collisions quite easily especially on systems with lots of files. Users of the shared memory class may want to specify a temporary file so that memory is only shared between specific groups of executing processes. Using a file's inode is a much better way to prevent collisions of this nature.