Various improvements to setup.py #399
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freso
commented
May 3, 2019
Freso
commented
May 3, 2019
Freso
force-pushed
the
task/improve-setup.py
branch
4 times, most recently
from
a798f26
to
cd87085
Compare
Use setup.py for Python dependency resolution and installing rather than specifying them individually in the .travis.yml file or in the requirements.txt file. See also https://caremad.io/posts/2013/07/setup-vs-requirement/ Signed-off-by: Frederik “Freso” S. Olesen <[email protected]>
See https://pypi.org/classifiers/ and https://packaging.python.org/guides/distributing-packages-using-setuptools/#classifiers Signed-off-by: Frederik “Freso” S. Olesen <[email protected]>
Signed-off-by: Frederik “Freso” S. Olesen <[email protected]>
Freso
force-pushed
the
task/improve-setup.py
branch
from
cd87085
to
3e6761e
Compare
Can otherwise cause issues with not being able to install PyGObject via pip/setuptools. List taken from https://gitlab.gnome.org/GNOME/pygobject/blob/master/setup.py#L135-143 Signed-off-by: Frederik “Freso” S. Olesen <[email protected]>
Freso
force-pushed
the
task/improve-setup.py
branch
from
3e6761e
to
79b1cd8
Compare
Signed-off-by: Frederik “Freso” S. Olesen <[email protected]>
|
If it's beneficial maybe this one could be resumed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.