Skip to content

Conversation

@EdwinWenink
Copy link

@EdwinWenink EdwinWenink commented Jun 29, 2024

Was looking at the repository trying to find out why only NAs were returned, made some linting improvements along the way. They are all minor, mainly:

  • Python loggers use old %s formatting for lazy evaluation
  • Removed unnecessary elifs/else return constructions to remove unneeded indentation
  • Timeouts on requests module are recommended because it doesnt time out by default
  • Minor stuff

@AndrewFBel
Copy link

Hey @EdwinWenink, this won't resolve the issue with NAs, will it?

@EdwinWenink
Copy link
Author

Unfortunately it won't, these are just some small changes for coding style. Doesn't add "value" in terms of functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants