Remove width attribute fallback from sizes calculation #5900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, given the non-support this seems fine to remove. @dholbert FYI. |
|
You can test this without changing DPI: http://software.hixie.ch/utilities/js/live-dom-viewer/saved/8439 |
zcorpan
approved these changes
Sep 9, 2020
annevk
approved these changes
Sep 10, 2020
3 tasks
eeeps
added a commit
to eeeps/html
that referenced
this pull request
Sep 20, 2021
...from the "Updating the source set" algorithm. Mop-up for Issue whatwg#5893, completing work started in PR whatwg#5900.
mfreed7
pushed a commit
to mfreed7/html
that referenced
this pull request
Jun 3, 2022
...from the "Updating the source set" algorithm. Mop-up for Issue whatwg#5893, completing work started in PR whatwg#5900.
This was referenced Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5893
@annevk - Can you confirm #5893 (comment) represents Mozilla's support?
Regarding WPTs - seems like this requires web-platform-tests/wpt#7140 in order to be WPT-testable (otherwise, the test would depend on the DPR of the screen on which it's running).
No need for implementation bugs, as this removes part of the spec that was not implemented anywhere.
(See WHATWG Working Mode: Changes for more details.)
/images.html ( diff )