-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Srcset implementations do not take width as a fallback when sizes is not present #5893
Comments
|
I think that change doesn't influence much for this behavior. The |
Hmm, wait. I was confused in my first comment. A clearer test is OK, since it's not implemented, removing it seems fine. |
Agreed. |
...from the "Updating the source set" algorithm. Mop-up for Issue whatwg#5893, completing work started in PR whatwg#5900.
...from the "Updating the source set" algorithm. Mop-up for Issue whatwg#5893, completing work started in PR whatwg#5900.
While looking into #4968, I noticed that HTML's parsing a sizes attribute is taking the image element's width into account as the fallback, in case
sizes
is not present.This used to make sense, before the changes made in WICG/intrinsicsize-attribute#16 (comment)
Since
width
no longer implies absolute pixel values, it no longer does, and I think we should remove that.Looking at the different implementations (test page - needs to be tested on 1 DPR screen), none of them treats
width
as the fallback value, meaning we can easily remove that from the spec.@zcorpan @annevk @chrishtr - thoughts?
The text was updated successfully, but these errors were encountered: