Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Last-Event-ID to CORS-safelisted request headers #1788

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rexxars
Copy link

@rexxars rexxars commented Nov 19, 2024

Since EventSource implementations in most environments already send this header without CORS preflight request, it makes sense to make it a safe-listed header.

See #568 for more background.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

@annevk
Copy link
Member

annevk commented Nov 19, 2024

@yoichio @KershawChang @youennf any final thoughts?

@annevk annevk added addition/proposal New features or enhancements topic: cors labels Nov 19, 2024
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your name to the Acknowledgments section! (Not required.)

@rexxars rexxars force-pushed the feat/cors-safelist-last-event-id branch from 76fc1a2 to 7a0ead3 Compare November 19, 2024 16:07
@rexxars
Copy link
Author

rexxars commented Nov 19, 2024

Please add your name to the Acknowledgments section! (Not required.)

Thanks! Done :)

@annevk annevk added the agenda+ To be discussed at a triage meeting label Nov 27, 2024
@annevk annevk removed the agenda+ To be discussed at a triage meeting label Nov 28, 2024
@smaug----
Copy link

smaug---- commented Dec 4, 2024

Gecko is interested, but how likely will this cause some webcompat issues?

Is #568 (comment) about the relevant change? Those numbers are going up, but still rather low.

Edit: looks like it was discussed here #568 (comment)

Since EventSource implementations in most environments already send this header
without CORS preflight request, it makes sense to make it a safelisted header.

See whatwg#568
@rexxars rexxars force-pushed the feat/cors-safelist-last-event-id branch from 7a0ead3 to b5a68d4 Compare January 15, 2025 19:59
@rexxars
Copy link
Author

rexxars commented Jan 15, 2025

From the WHATNOT meeting on 2024-12-05:

PA: haven't seen any comments from Chromium, assume Domenic is still looking. Let's wait for that and the response from the PR author on web compat.

👋 PR author here.

@yoichio commented on the related issue with this link which contains some statistics on this. It seems to me like these numbers are still very low, but I am also not a browser developer/maintainer, so I don't know what is generally considered low numbers on these sort of topics.

I'm interesting in moving this forward - it seems to have interest from Gecko and WebKit, and I have not heard any opposition yet. Should this be raised again in an upcoming WHATNOT meeting, or is there something I can do on my side to move this along?

@annevk
Copy link
Member

annevk commented Jan 16, 2025

Implementation bugs still have to be filed. That would help a bit. I'l flag it for the next meeting as well to check there's no opposition. (If you're up for it implementing it in a browser can also do wonders.)

@annevk annevk added the agenda+ To be discussed at a triage meeting label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition/proposal New features or enhancements agenda+ To be discussed at a triage meeting topic: cors
Development

Successfully merging this pull request may close these issues.

3 participants