Restore missing word in attach a shadow root
#1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 3, 2024
In [1] I mistakenly changed the check for whether an element has a valid shadow name to include the full qualified name rather than just the local name. Using only the local name is correct per the intent of the spec [2] (although the key word is missing from the spec due to a bug; see [3]). Fix this check (and the corresponding check for EditContext) to only include the local name. [1] https://chromium-review.googlesource.com/c/chromium/src/+/4617146 [2] https://dom.spec.whatwg.org/#concept-attach-a-shadow-root [3] whatwg/dom#1273 Bug: 331239166 Change-Id: Ic01b26ac592ce16c36017925db702f5b495b6165
mfreed7
approved these changes
Apr 4, 2024
|
Thanks Dan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore a term that was accidentally removed from step 2 of https://dom.spec.whatwg.org/#concept-attach-a-shadow-root in #892.
Preview | Diff