Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: injected connector throws error after switching to a chain that was just added via 'wallet_addEthereumChain'. #4311

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

chybisov
Copy link
Contributor

@chybisov chybisov commented Oct 2, 2024

Fixes the same issue encountered in #4227 and #4223 where the connector throws an error after switching to a chain that was just added via 'wallet_addEthereumChain' but for the injected connector.

…t was just added via `'wallet_addEthereumChain'`.
Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: 160fa84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@wagmi/core Patch
@wagmi/connectors Patch
wagmi Patch
@wagmi/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 6:03pm

@tmm
Copy link
Member

tmm commented Nov 6, 2024

Not able to reproduce this issue anymore. If you can supply a reproduction, happy to work on merging this.

@tmm tmm closed this Nov 6, 2024
@chybisov
Copy link
Contributor Author

chybisov commented Nov 7, 2024

@tmm hey, the issue is still there.

https://codesandbox.io/p/sandbox/wagmi-switchchain-forked-47mx8q

Steps

  1. Make sure BSC is not added to MetaMask
  2. Switch to Ethereum in MetaMask
  3. Connect and try to switch to BSC

Code that fails

const switchedChain = await switchChain(config, {
  chainId: chain.id,
});
const client = await getConnectorClient(config, {
  chainId: switchedChain.id,
});

Error

The current chain of the connector (id: 56) does not match the connection's chain (id: 1). Current Chain ID: 56 Expected Chain ID: 1 Version: @wagmi/[email protected]

@tmm tmm reopened this Nov 7, 2024
@tmm
Copy link
Member

tmm commented Nov 7, 2024

@chybisov thanks! made a small update.

@tmm tmm merged commit e08681c into wevm:main Nov 7, 2024
6 of 12 checks passed
@github-actions github-actions bot mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants