Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WIP i18n #95

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

codingwithmanny
Copy link
Contributor

@codingwithmanny codingwithmanny commented Feb 11, 2024

Context

Work-in-progress branch.
Adding support and examples for supporting multiple languages.

BREAKING CHANGE: No

Reference

Discussion #91

Features

i18n Feature:

  • vocs.config.ts - sidebar example i18n Playground
  • Top left logo link associated with respective locale see Sidebar.tsx
  • useLocale - Custom hook for current locale
  • Config support for defaultLocale and locales see i18n Playground vocs.config.ts
  • vocs.config.ts - topNav support for different languages
  • vocs.config.ts - description support for different languages
  • vocs.config.ts - editLink support for different languages
  • vocs.config.ts - title support for different languages
  • Desktop & Mobile Navs
  • Allow for translation to show on Mobile
  • Support translation for Previous and Next
  • Support Search translation

To see a demo, take a look at the i18n Playground

Added support and examples for supporting multiple languages

BREAKING CHANGE: N
Copy link

vercel bot commented Feb 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vocs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 2:09am

Allows for different types of titles and descriptions to exist for
different languages

BREAKING CHANGE: No
@codingwithmanny codingwithmanny marked this pull request as ready for review February 15, 2024 00:40
@codingwithmanny
Copy link
Contributor Author

codingwithmanny commented Feb 15, 2024

Fully expect there to be some refactoring, but thought about showing how we can support i18n with some native functionality as a base.

@codingwithmanny
Copy link
Contributor Author

Hey @jxom and @tmm any feedback with regards to this?

@taylanpince
Copy link

This is looking great and we would love to leverage it on our new docs site for Sequence that we've rebuilt using vocs. How can we help in getting it to the finish line? @codingwithmanny

@codingwithmanny
Copy link
Contributor Author

@taylanpince waiting for @tmm and @jxom to review. If you have any feedback with regards to it, let me know also.

@mhpaler
Copy link

mhpaler commented Jun 5, 2024

our new docs site for Sequence that we've rebuilt using vocs.

Very nice @taylanpince !!

@viv-cheung
Copy link

any updates on this PR? @tmm @codingwithmanny @jxom

@codingwithmanny
Copy link
Contributor Author

@viv-cheung 🤷‍♂️

@codingwithmanny
Copy link
Contributor Author

@Batdill if you approve the changes, happy to fix the conflicts, but just wanted to confirm before I put in the work that it would get merged because it's been a while. Let me know.

@Batdill
Copy link

Batdill commented Oct 16, 2024

Yes Thank you

@codingwithmanny
Copy link
Contributor Author

@Batdill let me know.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@floating-ui/[email protected], npm/@hono/[email protected], npm/@mdx-js/[email protected], npm/@mdx-js/[email protected], npm/@shikijs/[email protected], npm/@shikijs/[email protected], npm/@shikijs/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@Woods30
Copy link

Woods30 commented Nov 25, 2024

Looking forward to merging this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants