fix: avoid nonce gap in nonceManager (#3142) #3153
Open
+27
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3142 by deferring the nonce consumption in
prepareTransactionRequest
until after gas estimation succeeds, avoiding a nonce gap when gas estimation fails.Changes
nonceManager.consume(...)
is called after gas estimationDetails
nonceManager.consume(...)
before gas estimation, so if gas estimation failed, we never broadcast a transaction but had already incremented the nonce.prepareTransactionRequest
so that all fees and gas estimation happen first. Only if those steps succeed do we callconsume(...)
from the nonce manager. This way, no extra nonce is burned on failure.consume
entirely until the end, which is simpler and avoids the need for a rollback