Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZKsync: account hoisting fix for signEip712Transaction and sendEip712Transaction #3109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danijelTxFusion
Copy link
Contributor

Fix the account hoisting for signEip712Transaction and sendEip712Transaction. The actions only took account from parameters and did not check the account from client.

Copy link

changeset-bot bot commented Dec 9, 2024

🦋 Changeset detected

Latest commit: fb8b76f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 9, 2024

@danijelTxFusion is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Dec 10, 2024 7:49pm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate. Please remove.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@danijelTxFusion danijelTxFusion force-pushed the zksync/account-hoisting-fix branch 2 times, most recently from 70dc2af to 978bfba Compare December 10, 2024 19:26
@danijelTxFusion danijelTxFusion requested a review from jxom December 10, 2024 19:26
@danijelTxFusion danijelTxFusion force-pushed the zksync/account-hoisting-fix branch from 978bfba to 0a77901 Compare December 12, 2024 18:29
@jxom
Copy link
Member

jxom commented Dec 14, 2024

please rebase main

@danijelTxFusion danijelTxFusion force-pushed the zksync/account-hoisting-fix branch from 0a77901 to 33fef7c Compare December 14, 2024 14:31
@danijelTxFusion danijelTxFusion force-pushed the zksync/account-hoisting-fix branch from 33fef7c to fb8b76f Compare December 22, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants