Rethrow the original eth_sendTransaction
error if wallet_sendTransaction
isn't supported
#2965
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial stub at rethrowing the original
eth_sendTransaction
error ifwallet_sendTransaction
error isn't supported.I also modified the code a bit, so that
wallet_sendTransaction
is only tried once per client if not supported.PR-Codex overview
This PR focuses on improving error handling in the
sendTransaction
function by ensuring that original errors are rethrown when thewallet_sendTransaction
method is not supported. It enhances the logic for determining method support and improves test coverage.Detailed summary
sendTransaction
whenwallet_sendTransaction
isn't supported.wallet_sendTransaction
is unsupported.