-
-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to call deployed universal signature validator for chains that do not support createless call #2807
Conversation
… that do not support createless call
|
@coffeexcoin is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
This is related to #2484 as zksync is one of the chains that does not support createless deployment. This will add full support for ERC-6942 and ERC-1271 validation to zksync |
I don't think these HTTP test failures seem to be related to my changes - are you able to confirm that? |
src/chains/definitions/zksync.ts
Outdated
@@ -33,5 +33,9 @@ export const zksync = /*#__PURE__*/ defineChain({ | |||
multicall3: { | |||
address: '0xF9cda624FBC7e059355ce98a31693d299FACd963', | |||
}, | |||
universalSignatureVerifier: { | |||
address: '0x872146211f996755C8729042093ffb8660F8b129', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get these contracts verified please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated deployments for the new contract with the new function signature
Contracts are verified:
zksync mainnet
zksync sepolia
abstract testnet
…chains that do not support createless call (wevm#2807) * add ability to call deployed universal signature validator for chains that do not support createless call * fix import * remove unused isBytesEqual util * update function name to `isValidSig` * chore: tweaks * update addresse for new deployment --------- Co-authored-by: jxom <[email protected]>
Creates a new property on
chain.contracts
foruniversalSignatureVerifier
. Calling theverifyHash
action will prefer this deployed address over a createless deploy call. This is useful for chains that do not support createless calls (zk stack)Added deployed version of universal signature verifier to zksync, zksync sepolia, and abstract mainnet.
PR-Codex overview
This PR introduces a new
universalSignatureVerifier
feature across multiple files, implementing a signature verification mechanism and related deployment functions. It removes unused code and adds tests to ensure proper functionality.Detailed summary
universalSignatureVerifier
property inchain.ts
and various chain definitions.isValidSig
function inVerifySig
contract for signature validation.deployUniversalSignatureVerifier
function for deploying the verifier.verifyHash.test.ts
to include scenarios for the new verifier.isBytesEqual.ts
and associated tests as they were no longer needed.verifyHash.ts
to integrate the new verifier into the verification process.