Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: more twoslash #1735

Merged
merged 2 commits into from
Feb 6, 2024
Merged

docs: more twoslash #1735

merged 2 commits into from
Feb 6, 2024

Conversation

jxom
Copy link
Member

@jxom jxom commented Jan 25, 2024

PR-Codex overview

Detailed summary

  • Updated the version of vocs dependency from 1.0.0-alpha.30 to 1.0.0-alpha.34 in package.json.
  • Renamed client to publicClient in publicClient.ts.
  • Added imports and updated transport in walletClient.ts.
  • Removed line numbers and added code focus annotations in several markdown files.
  • Updated code examples and added code focus annotations in several markdown files.

The following files were skipped due to too many changes: site/pages/docs/utilities/toEventSignature.md, site/pages/docs/accounts/jsonRpc.md, site/pages/docs/utilities/toEventHash.md, site/pages/docs/utilities/toFunctionHash.md, site/pages/docs/migration-guide.mdx, site/pages/docs/actions/public/uninstallFilter.md, site/pages/docs/actions/public/getBlockNumber.md, site/pages/docs/actions/public/estimateMaxPriorityFeePerGas.md, site/pages/docs/utilities/toEventSelector.md, site/pages/docs/actions/public/getFilterLogs.md, site/pages/docs/actions/public/getProof.md, site/pages/docs/contract/getContractEvents.md, site/pages/docs/contract/createContractEventFilter.md, site/pages/docs/actions/public/getTransactionReceipt.md, site/pages/docs/actions/public/getBlockTransactionCount.md, site/pages/docs/accounts/signMessage.md, site/pages/docs/actions/public/estimateFeesPerGas.md, site/pages/docs/accounts/privateKey.md, site/pages/docs/contract/decodeEventLog.md, site/pages/docs/actions/public/getTransactionConfirmations.md, site/pages/docs/actions/wallet/sendRawTransaction.md, site/pages/docs/actions/public/getTransactionCount.md, site/pages/docs/actions/public/getFeeHistory.md, site/pages/docs/actions/public/watchBlockNumber.md, site/pages/docs/accounts/local.md, site/pages/docs/actions/public/getBlock.md, site/pages/docs/actions/public/getBalance.md, site/pages/docs/accounts/hd.md, site/pages/docs/actions/wallet/watchAsset.md, site/pages/docs/accounts/mnemonic.md, site/pages/docs/actions/public/waitForTransactionReceipt.md, site/pages/docs/actions/public/watchPendingTransactions.md, site/pages/docs/actions/public/getTransaction.md, site/pages/docs/actions/public/getFilterChanges.md, site/pages/docs/actions/public/watchBlocks.md, site/pages/docs/clients/public.md, site/pages/docs/actions/public/verifyMessage.md, site/pages/docs/actions/wallet/signMessage.md, site/pages/docs/accounts/signTransaction.md, site/pages/docs/actions/wallet/signTypedData.md, site/pages/docs/actions/public/estimateGas.md, site/pages/docs/actions/wallet/sendTransaction.md, site/pages/docs/actions/wallet/signTransaction.md, site/pages/docs/actions/public/call.md, site/pages/docs/actions/public/watchEvent.md, site/pages/docs/actions/public/createEventFilter.md, site/pages/docs/actions/public/getLogs.md, site/pages/docs/actions/public/verifyTypedData.md, site/pages/docs/actions/wallet/prepareTransactionRequest.md, site/pages/docs/ethers-migration.mdx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jan 25, 2024

⚠️ No Changeset found

Latest commit: bd77e2a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Feb 6, 2024 1:38am

Copy link

socket-security bot commented Jan 25, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment, filesystem Transitive: eval, network, shell, unsafe +408 309 MB jmoxey

🚮 Removed packages: npm/[email protected]

View full report↗︎

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (403e42a) 97.56% compared to head (edbc335) 97.56%.

❗ Current head edbc335 differs from pull request most recent head bd77e2a. Consider uploading reports for the commit bd77e2a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1735   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files         522      522           
  Lines       46823    46823           
  Branches     2154     2156    +2     
=======================================
  Hits        45684    45684           
  Misses       1112     1112           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jxom jxom marked this pull request as ready for review February 6, 2024 01:35
@jxom jxom changed the title docs: twoslash everything docs: more twoslash Feb 6, 2024
@jxom jxom merged commit c266d95 into main Feb 6, 2024
21 of 23 checks passed
@jxom jxom deleted the jxom/more-twoslash branch February 6, 2024 01:35
@tmm tmm mentioned this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant