fix: avoid nonce gap in nonceManager (#3142) #3153
Open
+27
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ec689f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@0xrouss is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3142 by deferring the nonce consumption in
prepareTransactionRequestuntil after gas estimation succeeds, avoiding a nonce gap when gas estimation fails.Changes
nonceManager.consume(...)is called after gas estimationDetails
nonceManager.consume(...)before gas estimation, so if gas estimation failed, we never broadcast a transaction but had already incremented the nonce.prepareTransactionRequestso that all fees and gas estimation happen first. Only if those steps succeed do we callconsume(...)from the nonce manager. This way, no extra nonce is burned on failure.consumeentirely until the end, which is simpler and avoids the need for a rollback