Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Byline: adding documentation, moving to main title #2452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Byline: adding documentation, moving to main title #2452

wants to merge 1 commit into from

Conversation

Garneauma
Copy link
Contributor

@Garneauma Garneauma commented Dec 11, 2024 •
edited
Loading

  • Adding byline documentation so that it can be deprecated
  • Adding "Main page title with byline" variation to the Main page title (this variation is limited to news pages on Canada.ca)

Related to WET-494

@Garneauma
Copy link
Contributor Author

@duboisp I have set the status of the byline component to deprecated. However, if we want to get this pull request out without triggering a major release, I can change it to demoted instead.

@Garneauma
Copy link
Contributor Author

Pre-approved upon successful review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@duboisp duboisp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Garneauma @duboisp