Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#119: 회원가입, 투표 로그 추가 #125

Merged
merged 9 commits into from
Aug 22, 2024

Conversation

flash159483
Copy link
Contributor

1. 📄 관련된 이슈 및 소개

close #119

2. 🔥 변경된 점

로깅시 id 반드시 추가하는 로깅 도입

3. ✅ 필수 체크 사항

  • 회원가입에 logging 추가해요
  • 투표에 logging 추가해요

4. 📸 작업물 사진 공유(선택)

5. 💡알게된 혹은 궁금한 사항

@flash159483 flash159483 added 🌱기능🌱 새로운 기능을 추가해요 ! 🍩브라우니🍩 24기 정승원 🔥리뷰 기다리는 중🔥 PR을 올리고 코드리뷰를 기다리고 있는 상태입니다. labels Aug 21, 2024
@flash159483 flash159483 requested a review from jeongjaino August 21, 2024 14:41
@flash159483 flash159483 self-assigned this Aug 21, 2024
@flash159483 flash159483 force-pushed the feature/flash159483/#119 branch from 753dca6 to 84a18f5 Compare August 21, 2024 14:53
@flash159483 flash159483 reopened this Aug 21, 2024
Copy link
Member

@jeongjaino jeongjaino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! GOGOGOOGOOOGOGOGOGOGOGOGO

@github-actions github-actions bot added the 🌟머지 해주세요🌟 코드 리뷰가 완료된 뒤 PR을 올린사람이 Merge를 하면 되는 단계입니다. label Aug 22, 2024
@flash159483 flash159483 merged commit 4f1c2bc into develop Aug 22, 2024
4 checks passed
@flash159483 flash159483 deleted the feature/flash159483/#119 branch August 22, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟머지 해주세요🌟 코드 리뷰가 완료된 뒤 PR을 올린사람이 Merge를 하면 되는 단계입니다. 🌱기능🌱 새로운 기능을 추가해요 ! 🍩브라우니🍩 24기 정승원 🔥리뷰 기다리는 중🔥 PR을 올리고 코드리뷰를 기다리고 있는 상태입니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WS-399 [FEATURE]: 회원가입, 투표에 Logging 추가해요
2 participants