Use custom external interpreter by default #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpickering
reviewed
Jan 21, 2026
alt-romes
force-pushed
the
wip/romes/external-interp
branch
5 times, most recently
from
66bdfb6 to
cd87dbf
Compare
Launch the custom-for-the-debugger external interpreter for running the debuggee process. Using an external interpreter will guarantee the debugger and debuggee run on separate processes. This comes with many benefits: * Debugger vs debuggee threads naturally separated * Debugger vs debuggee stdin/stdout/stderr naturally separated * No *** Ignoring breakpoint when debugging the debugger against another program A custom server is necessary for the custom commands (starting with GHC 9.16) and because the external interpreter in GHC 9.14 is not compiled with -threaded, which is a requirement for using thread/stack cloning messages in the external process. See also Note [Custom external interpreter] Fixes #169
Ultimately, we want to connect the debuggee handles directly to the DAP output streams, however, that will be done in a followup MR. Using inherited handles here lets us finish this patch independently of that.
alt-romes
force-pushed
the
wip/romes/external-interp
branch
2 times, most recently
from
618a9f8 to
2d3fb59
Compare
…om external interpreter Revert "external-interp: Inherit the debugger's handles" This reverts commit 7b96e498ee431b9067131a96566a9823f89cc9d0. Wrong way about Revert "Wrong way about" This reverts commit cc4b510e5426102b89a37c76051b6138fa210bb7. Killing Recorder, cleaning logs Killing... WIP use iserv handles WIP 90% Cleaning service Clean clean..2 Compiles
alt-romes
force-pushed
the
wip/romes/external-interp
branch
from
2d3fb59 to
7c0a797
Compare
…rpreter by default. The one after: test both external and internal interpreter on CI
alt-romes
force-pushed
the
wip/romes/external-interp
branch
from
d474243 to
caedd61
Compare
Re-enabling them is tracked by #181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #169