Backport patches for sbin merge and glibc move to /usr/ #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When packages are rebuilt in an environment with merged sbin, files move from /usr/sbin to /usr/bin. 'runtime-cleanup' was wreaking havoc on such installations, removing 'losetup', 'mkswap', and other crucial utilities. (https://bodhi.fedoraproject.org/updates/FEDORA-2024-3aafcac6a8#comment-3609189) The rules for the change: - for single names, /sbin/ is replaced by /*bin/. E.g. /usr/sbin/chpasswd → /usr/*bin/chpasswd. This is easy, because we want to match 'chpasswd' no matter where it is installed. - in some cases, there was a glob, but the rpm only has files in /usr/sbin, so we can apply the same substition and match those files no matter where they are installed. - in some other cases, there was a glob, but it only matched a single file in /usr/sbin, and the package has other files in /usr/bin. In those cases, we need to adjust the glob to be more specific, e.g. /usr/sbin/* → /usr/*bin/iconvconfig for glibc. This should be safe with unmerged packages, and should unbreak builds on with merged packages.
Add wildcards to the paths so that runtime-cleanup works with either location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.