Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handles string as package name #1667

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

pyther-hub
Copy link

@pyther-hub pyther-hub commented Feb 15, 2023

solved the issue #1638 by simply converting the string to list element
rdt.display_all_rdataset_names("aer")
the above command works same as
rdt.display_all_rdataset_names(["aer"])

as now the code converts the string back to a list with one element its a simple way to solve this
image

image
as you con see in the screenshots the output is same

@henrykironde
Copy link
Contributor

@Nageshbansal by any chance, do you have time to review this patch?

@Nageshbansal
Copy link
Contributor

Yeah sure.

@pyther-hub
Copy link
Author

@Nageshbansal if there is any problem in this pr please do let me know

@pyther-hub
Copy link
Author

pyther-hub commented Feb 21, 2023

Sir please look into it @Nageshbansal

@Nageshbansal
Copy link
Contributor

I will review this PR along with PR #1664 during this week.

@pyther-hub
Copy link
Author

sir please have a look to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants