Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 fix Unstructured metadata types #47

Merged
merged 1 commit into from
May 7, 2024
Merged

fix: 🐛 fix Unstructured metadata types #47

merged 1 commit into from
May 7, 2024

Conversation

self-transition
Copy link
Member

@self-transition self-transition commented May 6, 2024 •
edited
Loading

BREAKING CHANGE: 🧨 Unstructured.metadata changed to optional

Since the previous type was inaccurate, it was adjusted to match the type of the k8S core resource and CRD.
image
image

fix: 🐛 fix Unstructured metadata types
d68e790 
BREAKING CHANGE: 🧨 `Unstructured.metadata` changed to optional
@self-transition self-transition added the enhancement New feature or request label May 6, 2024
@huangjunjia
Copy link

Why do you want to modify this property?

@self-transition
Copy link
Member Author

Why do you want to modify this property?

Since the previous type was inaccurate, it was adjusted to match the type of the k8S core resource and CRD.
image
image

huangjunjia
huangjunjia approved these changes May 7, 2024
View reviewed changes
Copy link

@huangjunjia huangjunjia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@self-transition self-transition merged commit 875d022 into main May 7, 2024
1 check passed
@self-transition self-transition deleted the xingyu/fix_types branch May 7, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huangjunjia huangjunjia huangjunjia approved these changes

@MrWindlike MrWindlike Awaiting requested review from MrWindlike

@tanbowensg tanbowensg Awaiting requested review from tanbowensg

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@self-transition @huangjunjia