Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call restoreItem func of plugins in reversed order #31

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

tanbowensg
Copy link
Member

Bug 描述

现在对model调用 restoreItem 时,结果仍然会有relations,没有restore干净。

原因

目前Plugin的proceesItem和restoreItem都是按顺序调用的。目前的顺序是 [relationPlugin, modelPlugin]。结果就是先调用了的relationPlugin的restoreItem,去掉了relation。但是modelPlugin的restoreItem直接返回了rawYaml,导致结果还是有relation。应该反过来,先拿到rawYaml,再去掉relation才正确。

因此,在restoreItem的时候按照plugins的反向顺序调用更加合理一些。

@MrWindlike MrWindlike merged commit 8973551 into main Feb 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants