fix(kube-api): add 'forceApply' parameter to kube-api #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
self-transition
force-pushed
the
xingyu/fix-kube-api
branch
from
55d45d5 to
646b63e
Compare
|
没太懂这个 flag 的预期。使用场景是什么 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original implementation, we would call the put and patch api in applyYaml to get whether the current resource exists or not, but at the time we assumed that all applyYaml's carried the '--force' parameter.
However, when two resources with the same name are placed by different users, the latter will be incorrectly called by the patch api and override the earlier.
In this MR, we have added the forceApply parameter and set it to false when calling create.When it's not forceApply and the resource exists, throw an error.