add k8s api provider plugins #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanbowensg
force-pushed
the
bowen/remove-model-reabase
branch
from
cc2c89f to
6d6ecb0
Compare
tanbowensg
changed the title
tanbowensg
changed the title
tanbowensg
force-pushed
the
bowen/remove-model-reabase
branch
from
6d6ecb0 to
f67b013
Compare
tanbowensg
changed the title
tanbowensg
force-pushed
the
bowen/remove-model-reabase
branch
from
f67b013 to
fce1b02
Compare
tanbowensg
force-pushed
the
bowen/remove-model-reabase
branch
from
fce1b02 to
332cc7b
Compare
tanbowensg
force-pushed
the
bowen/remove-model-reabase
branch
from
bb1b153 to
176632c
Compare
MrWindlike
reviewed
Jan 8, 2024
| PhaseColumnRenderer(), | ||
| NameColumnRenderer('jobs'), | ||
| NameSpaceColumnRenderer(), | ||
| WorkloadImageColumnRenderer(), | ||
| CompletionsCountColumnRenderer(), | ||
| DurationColumnRenderer(), | ||
| AgeColumnRenderer(), | ||
| ]; | ||
| ] as Column<ResourceModel>[]; |
| const newOne = cloneDeep(this._rawYaml); | ||
| const path = 'spec.template.metadata.annotations'; | ||
| const annotations = get(newOne, path, {}); | ||
| set(newOne, path, { |
There was a problem hiding this comment.
应该要使用 immutable set，不要修改到原来的值，否则更新失败的时候数据会对不上
MrWindlike
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
改动
DovetailCRUD一般不再需要传formatter了，因为plugin里面都已经格式化好了。但暂时没有全部删掉，以防一些特殊需求。restoreItem方法