Skip to content

refactor: enhance Family type#27

Merged
antongolub merged 1 commit intomainfrom
refactor-family-type
Sep 28, 2025
Merged

refactor: enhance Family type#27
antongolub merged 1 commit intomainfrom
refactor-family-type

Conversation

@antongolub
Copy link
Member

No description provided.

@antongolub antongolub requested a review from Copilot September 28, 2025 15:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Family type by introducing a new FamilyAlias type that extends the original Family type with additional string representations for IPv4 and IPv6, and renames the parameter name to kind in the addresses-related functions for better semantic clarity.

  • Introduces FamilyAlias type to support multiple string formats for IP family specification
  • Renames parameter name to kind in addresses and address functions for clarity
  • Updates size limits to accommodate the changes

Reviewed Changes

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/main/ts/core.ts Adds FamilyAlias type definition and updates function signatures to use it
src/main/ts/native.ts Updates function parameters to use FamilyAlias and renames name to kind
target/esm/index.mjs Compiled output reflecting the parameter rename from name to kind
target/cjs/index.cjs Compiled output reflecting the parameter rename from name to kind
.size-limit.json Updates bundle size limits to reflect the changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@antongolub antongolub added the enhancement New feature or request label Sep 28, 2025
@antongolub antongolub merged commit 0ff2aca into main Sep 28, 2025
21 checks passed
@antongolub antongolub deleted the refactor-family-type branch September 28, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments