Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Family type by introducing a new FamilyAlias type that extends the original Family type with additional string representations for IPv4 and IPv6, and renames the parameter name to kind in the addresses-related functions for better semantic clarity.
- Introduces
FamilyAliastype to support multiple string formats for IP family specification - Renames parameter
nametokindinaddressesandaddressfunctions for clarity - Updates size limits to accommodate the changes
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/ts/core.ts | Adds FamilyAlias type definition and updates function signatures to use it |
| src/main/ts/native.ts | Updates function parameters to use FamilyAlias and renames name to kind |
| target/esm/index.mjs | Compiled output reflecting the parameter rename from name to kind |
| target/cjs/index.cjs | Compiled output reflecting the parameter rename from name to kind |
| .size-limit.json | Updates bundle size limits to reflect the changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.