feat: autocomplete (rebase) #4327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(deps-dev): bump webpack-dev-server from 5.0.2 to 5.0.3 (webpack#4108)
|
Here is the rebase version an existing pull request I had made regarding autocomplete feature as said by sir @evenstensberg. Had to close the previous pr. I would love to take on this issue again if possible. Best. |
|
There's still conflicts |
| @@ -0,0 +1,152 @@ | |||
| import * as Fs from "fs"; | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-var-requires | |||
| return omelette(appNameOnAutocomplete); | ||
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any |
There was a problem hiding this comment.
dont disable lint rules, they're there for a reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature #1402
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information