Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement support for array values in from property. Closes #631 #645

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

orangy
Copy link

@orangy orangy commented Nov 23, 2021

This PR contains an implementation for processing arrays in from property, and is:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

In my project I'm missing transformAll on a bunch of files, so I've found a recent issue #631 and decided to implement it.

Breaking Changes

There shouldn't be any breaking changes since it doesn't disable or break any scenario that was possible before, and only creates new (wonderful!) possibility to make copy scripts shorter and more powerful.

Additional Info

`Invalid "pattern.from": ${item.from}, every element should be a string"`
)
);
}
Copy link
Member

@alexander-akait alexander-akait Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid it, you validate it in schema already

)
)
))
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not pass array to globby? They support it https://github.com/sindresorhus/globby#usage

},
"to": {
"anyOf": [
"oneOf": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it was changed?

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes

@jasper2virtual
Copy link

Hi, I need this feature too, I notice this PR is stopped for a year, what can I do or contribute to make it go?

@alexander-akait
Copy link
Member

Yes, feel free to send a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants