Add @psalm-pure
to the typeToString
method
#303
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When extending the
Assert
class it can be difficult to keep custom methods pure, especially when opting for the use of theAssert::typeToString
method. This results in the following Psalm error at the call to thetypetoString
method:Currently there are two options to avoid the error:
ImpureMethodCall
psalm error for your custom pure method.Ideally you neither pick one of those options.
This PR fixes the error for good error by marking the
Assert::typeToString
method as@psalm-pure
.