Add support for comment websocket messages #5577
Open
+361
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsisak
added
review-needed
|
Is there a backend PR? |
See webkom/lego#3835 |
|
Dont know if all the redux things is correct. I keep getting "An input selector returned a different result when passed same arguments" as warning. I also created a component that handles all the ws group logic. It passes on status and even a nice little component indicating the status. |
itsisak
force-pushed
the
comment-websockets
branch
from
ffd67e4 to
e1ff38d
Compare
itsisak
force-pushed
the
comment-websockets
branch
from
e1ff38d to
8b5fafb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make it possible for comments to be updated live using websockets.
Backend PR for sending ws messages in progress
Result
Using different browsers:
Screen.Recording.2025-05-12.at.12.14.05.mov
Testing