Skip to content

Conversation

emillub
Copy link
Contributor

@emillub emillub commented Mar 26, 2025

Description

Add a util-function to get the download-url
Add a button to administrate/attendees

Result

If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.

  • [ x ] Changes look good on both light and dark theme.
  • [ x ] Changes look good with different viewports (mobile, tablet, etc.).
  • [ x ] Changes look good with slower Internet connections.

Caution

Make sure your images do not contain any real user information.
Before:

image

After:
image

Testing

  • I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.


Backend PR: webkom/lego#3811
Resolves ABA-870

Copy link

linear bot commented Mar 26, 2025

Copy link

vercel bot commented Mar 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2025 8:58pm

@github-actions github-actions bot added the review-needed Pull requests that need review label Mar 26, 2025
Copy link
Contributor

@christiangryt christiangryt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But why are there changes to acheivments?

@emillub
Copy link
Contributor Author

emillub commented Apr 14, 2025

LGTM! But why are there changes to acheivments?

Because there were unused imports which made the tests not pass, i think. Should I remove it from the commit?

Copy link
Contributor

@Arashfa0301 Arashfa0301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants