feat(pulumi-aws): deploy environment variant #4501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunozoric
requested review from
Pavel910 and
adrians5j
and removed request for
Pavel910
brunozoric
force-pushed
the
bruno/feat/pulumi-aws/deploy-variant
branch
from
cb6d172 to
8694dea
Compare
brunozoric
force-pushed
the
bruno/feat/pulumi-aws/deploy-variant
branch
from
8694dea to
61bea26
Compare
adrians5j
approved these changes
Jan 24, 2025
| @@ -4,6 +4,8 @@ import { CliContext, ProjectApplication } from "@webiny/cli/types"; | |||
| export interface CallableParams { | |||
| inputs: Record<string, any>; | |||
| env: string; | |||
| // TODO put to optional | |||
There was a problem hiding this comment.
Is this for later or should this be done now?
| @@ -9,6 +9,8 @@ export function getStackOutput<TStackOutput = Record<string, unknown>>( | |||
| export function getStackOutput<TStackOutput = Record<string, any>>(options: { | |||
| folder: string; | |||
| env: string; | |||
| // TODO put to optional | |||
| @@ -30,6 +30,7 @@ export default { | |||
| getStackOutput({ | |||
| folder: "project-applications-path/api", | |||
| env: options.env, | |||
| variant: options.variant, | |||
There was a problem hiding this comment.
We should probably just delete this whole package. :D
Maybe we can discuss this with Pavel.
There was a problem hiding this comment.
I think we can also delete this. Let's check with @Pavel910 .
| @@ -19,7 +19,11 @@ export type PulumiProgram<TApp = PulumiApp, TResources = Record<string, any>> = | |||
| ) => TResources | Promise<TResources>; | |||
|
|
|||
| export type CreateConfig = Record<string, any>; | |||
| export type RunConfig = Record<string, any>; | |||
| // TODO bring back Record<string, any> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR will pass the --variant variable into all methods that rely on it to produce a correct Pulumi response.
How Has This Been Tested?
Manually.