feat(admin-ui): Toast component #4249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrians5j
requested changes
Oct 29, 2024
| </App> | ||
| </WcpProvider> | ||
| </UiProviders> | ||
| {/*<UiProviders>*/} |
There was a problem hiding this comment.
This needs to stay commented out?
| export const WithDescription: Story = { | ||
| args: { | ||
| ...Default.args, | ||
| description: <ToastDescription text={'Entry "Article One" has been successfully created'} /> |
There was a problem hiding this comment.
Noticed this here, and thinking we should do the same approach I have here.
So, in this case, we'd end up prolly with Toast.Description. Wdyt?
BTW not sure if applicable here, but I did this withStaticProps helper within the Avatar PR, just to make it a bit more humane when sticking extra components as static properties on an existing React component / class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
Toastcomponent to the@webiny/admin-uipackage.We are exporting a props-based flat component based on the following radix component.
The new component is fully compatible with the old
Snackbarcomponent, but some refactoring is needed when UI tokens are defined.The
useSnackbarhook is fully compatible with the new Toast component. Refactoring the hook will be necessary; a separate PR will address it.