Skip to content
This repository has been archived by the owner on Jan 6, 2024. It is now read-only.

feat: supports filtering documents #89

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

liuseen-l
Copy link
Contributor

20230630_004627.mp4

@alexzhang1030
Copy link
Collaborator

Maybe fuzzy search is better, refer to useFuse

@liuseen-l
Copy link
Contributor Author

@alexzhang1030 thanks for your suggestion, I'll check it out

@webfansplz
Copy link
Owner

Thanks for the PR, but I don't think we need it for the while, because there's not much data and it's easy to look it up.

@liuseen-l
Copy link
Contributor Author

liuseen-l commented Jun 30, 2023

Thanks for the PR, but I don't think we need it for the while, because there's not much data and it's easy to look it up.

Is it possible to support user-defined adding documents? what I think is that users can customize and add some documents in it, which may lead to a large number of documents

@webfansplz
Copy link
Owner

Thanks for the PR, but I don't think we need it for the while, because there's not much data and it's easy to look it up.

Is it possible to support user-defined adding documents? what I think is that users can customize and add some documents in it, which may lead to a large number of documents

Yes, we may add the ability to customize tabs and documents in the future. So let's hold this PR until we support it.

@webfansplz webfansplz added the on hold This PR won't merge in short time. label Jul 6, 2023
@liuseen-l liuseen-l force-pushed the chore/document branch 3 times, most recently from 80840e3 to 9d80bf0 Compare July 6, 2023 03:32
@liuseen-l
Copy link
Contributor Author

liuseen-l commented Jul 6, 2023

@webfansplz adding and deleting documents is now supported, and the filtering method of document query is changed to fuzzy query

@liuseen-l
Copy link
Contributor Author

liuseen-l commented Jul 6, 2023

output.compress-video-online.com.1.mp4

@webfansplz cc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
on hold This PR won't merge in short time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants