Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): Update CONTRIBUTING.md #3680

Open
wants to merge 35 commits into
base: next
Choose a base branch
from
Open

fix(docs): Update CONTRIBUTING.md #3680

wants to merge 35 commits into from

Conversation

Kesari3008
Copy link
Contributor

@Kesari3008 Kesari3008 commented Jul 2, 2024 •
edited
Loading

COMPLETES #Ad-Hoc

This pull request addresses

Updating the build command in the contributing.md file as per new tooling

by making the following changes

Updating the build command in the contributing.md file as per new tooling

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

Kesari3008 and others added 30 commits August 14, 2023 20:44
@Kesari3008 @sreenara
fix(plugin-meetings): added error for transcription not starting when…
68fc86b 
… guest joins first (#2993)

Co-authored-by: Priya Kesari <[email protected]>
Co-authored-by: Sreekanth Narayanan (sreenara) <[email protected]>
docs(api): update docs [skip ci]
0225bb2
chore(release): v2.59.1 [skip ci]
5b90cc1
@rajeshtezu
chore: add notice to raise further PRs against next branch (#3019)
3e2d9e1
docs(api): update docs [skip ci]
0946868
@rajeshtezu
chore: remove html & css styles from notice (#3022)
b9ac76b
docs(api): update docs [skip ci]
d3511ce
@Shreyas281299
fix(plugin-meetings): no-frames-received-sent-stats-error (#3017)
8c8cb6e
docs(api): update docs [skip ci]
293a3c0
chore(release): v2.59.2 [skip ci]
c170725
@Shreyas281299 @ShreyasSharma28
fix(meeting): added noFramesSent noVideoEncoded events (#3041)
d0c3188 
Co-authored-by: Shreyas Sharma <[email protected]>
docs(api): update docs [skip ci]
8db754f
chore(release): v2.59.3 [skip ci]
e5c1007
@arun3528
fix(plugin-meetings): enable adhoc and unified space meeting by defau…
36c6022 
…lt (#3137)
docs(api): update docs [skip ci]
c93b810
chore(release): v2.59.4 [skip ci]
e27c00a
@Shreyas281299 @marcin-bazyl
fix(plugin-meetings): cherry-picked-PR-2782-from-beta (#3160)
1acaac5 
Co-authored-by: Marcin <[email protected]>
docs(api): update docs [skip ci]
2389b87
chore(release): v2.59.5 [skip ci]
03afe2c
@Neeraj-swarnkar
fix(meetings): pass encrypted title based on APPI API for conversation (
080d786 
#3166)
docs(api): update docs [skip ci]
50176fb
chore(release): v2.59.6 [skip ci]
5aff0c0
@meta-dipanshu-sharma
fix(plugin-meetings): start transcription when guest user is admitted (…
e4c31a0 
…#3195)

Co-authored-by: Dipanshu Sharma <[email protected]>
docs(api): update docs [skip ci]
6f0b539
chore(release): v2.59.7 [skip ci]
799bea1
@Kesari3008
fix(services): added hostCatalog inside webex (#3198)
cdaddc2 
Co-authored-by: Priya Kesari <[email protected]>
docs(api): update docs [skip ci]
975797e
chore(release): v2.59.8 [skip ci]
19658c8
@sreenara
feat(meetings): add ability to reclaim host role with hostKey (#3291)
137b528
docs(api): update docs [skip ci]
f7f9d94
@Kesari3008 Kesari3008 requested a review from a team as a code owner July 2, 2024 11:41
@Kesari3008 Kesari3008 added the validated If the pull request is validated for automation. label Jul 2, 2024
@Kesari3008 Kesari3008 changed the title Update CONTRIBUTING.md fix(docs): Update CONTRIBUTING.md Jul 2, 2024
mkesavan13
mkesavan13 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@mkesavan13 mkesavan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

mkesavan13
mkesavan13 requested changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@mkesavan13 mkesavan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is raised against master branch.

Kindly check and raise against the next branch.

@Kesari3008 Kesari3008 changed the base branch from master to next July 2, 2024 12:59
@Kesari3008 Kesari3008 requested a review from a team as a code owner July 2, 2024 12:59
@Kesari3008
Copy link
Contributor Author

The PR is raised against master branch.

Kindly check and raise against the next branch.

My bad. Updated now. Thanks for pointing it out.

@sreenara
Copy link
Contributor

@Kesari3008 do we need this PR open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkesavan13 mkesavan13 mkesavan13 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
validated If the pull request is validated for automation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Kesari3008 @sreenara @mkesavan13 @rajeshtezu @Shreyas281299 @arun3528 @Neeraj-swarnkar @meta-dipanshu-sharma