feat(meetings): timeout for cluster discovery request (#4004)

webex · Nov 25, 2024 · 7e0ed3c · 7e0ed3c
1 parent 30d29dd
commit 7e0ed3c
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 8 deletions.
diff --git a/packages/@webex/plugin-meetings/src/config.ts b/packages/@webex/plugin-meetings/src/config.ts
@@ -95,5 +95,6 @@ export default {
     // This only applies to non-multistream meetings
     iceCandidatesGatheringTimeout: undefined,
     backendIpv6NativeSupport: false,
+    reachabilityGetClusterTimeout: 5000,
   },
 };
diff --git a/packages/@webex/plugin-meetings/src/reachability/request.ts b/packages/@webex/plugin-meetings/src/reachability/request.ts
@@ -46,6 +46,7 @@ class ReachabilityRequest {
               JCSupport: 1,
               ipver: ipVersion,
             },
+            timeout: this.webex.config.meetings.reachabilityGetClusterTimeout,
           }),
         'internal.get.cluster.time'
       )

diff --git a/packages/@webex/plugin-meetings/test/unit/spec/reachability/request.js b/packages/@webex/plugin-meetings/test/unit/spec/reachability/request.js
@@ -57,18 +57,23 @@ describe('plugin-meetings/reachability', () => {
         }
       }));
 
+      webex.config.meetings.reachabilityGetClusterTimeout = 3000;
+
       const res = await reachabilityRequest.getClusters(IP_VERSION.only_ipv4);
       const requestParams = webex.request.getCall(0).args[0];
 
-      assert.equal(requestParams.method, 'GET');
-      assert.equal(requestParams.resource, `clusters`);
-      assert.equal(requestParams.api, 'calliopeDiscovery');
-      assert.equal(requestParams.shouldRefreshAccessToken, false);
-
-      assert.deepEqual(requestParams.qs, {
-        JCSupport: 1,
-        ipver: 4,
+      assert.deepEqual(requestParams, {
+        method: 'GET',
+        resource: `clusters`,
+        api: 'calliopeDiscovery',
+        shouldRefreshAccessToken: false,
+        qs: {
+          JCSupport: 1,
+          ipver: 4,
+        },
+        timeout: 3000,
       });
+
       assert.deepEqual(res.clusters.clusterId, {udp: "testUDP", isVideoMesh: true})
       assert.deepEqual(res.joinCookie, {anycastEntryPoint: "aws-eu-west-1"})
       assert.calledOnceWithExactly(webex.internal.newMetrics.callDiagnosticLatencies.measureLatency, sinon.match.func, 'internal.get.cluster.time');